-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mark talk as Watched/Unwatched #383
Conversation
@marcoroth @adrienpoly any idea why CI is failing? ![]() |
This is the test that run the entire seed, it only runs in the CI as it is fairly long this is why you probably don't see this error in dev. To go back to the error by itself I had a similar case in the past. I think we might have to either remove the constraint or make it deferrable More info here : |
I had issues with CI
Thanks, @adrienpoly ! I had to remove the constraint because making it deferrable didn't work. |
ca98c66
to
aa6f659
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great, thanks @nicogaldamez! 🙌🏼
I think I only have one minor thing about the icon for the "unwatch" action, but other than that this looks great to me!
@adrienpoly that shouldn't happen. When you mark a talk as watched, the button should change to "Unwatched", and it shouldn't try to mark it as watched again. Anyway, I replaced the Let me know if you still have any problems. |
Thanks for working on this @nicogaldamez. I slightly tweaked the styles of the button. Before I was slightly confused in which state a video is. I hope this improves the usability aspect a bit and hope you don't mind. 🙌🏼 |
@marcoroth I love it 🤩 |
Why?
What?