Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

load topics talks in a turbo frame #440

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from
Draft

Conversation

adrienpoly
Copy link
Owner

for now I would like to test this only for admin to play a bit with it to be sure they are no side effects.

@marcoroth
Copy link
Collaborator

Does this really make a difference? A talk usually only has 4-5 topics, no?

@adrienpoly
Copy link
Owner Author

It is not for displaying the topics of a talk but to display the talks of a topic.
like for this page https://www.rubyvideo.dev/topics/abstract-syntax-tree-ast

Given the filter introduce in #433 we can now display within a turbo frame the talks of a topics and we could extend that to speaker#show page and event#show page. That would DRY quite a bit the rendering of talks card.

@adrienpoly
Copy link
Owner Author

ok I wen't much further :

  • added infinite scroll to the talks index view to remove pagination
  • all talks grid view in Events#show, Speakers#show, Topics#show are now displayed using the same turbo frame from the talks#index view

The benefits I see is to dry a bit that part of the views and when we start adding filters, sorting etc that can be added globaly to all views

@adrienpoly adrienpoly marked this pull request as draft November 26, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants