-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
load topics talks in a turbo frame #440
base: main
Are you sure you want to change the base?
Conversation
Does this really make a difference? A talk usually only has 4-5 topics, no? |
It is not for displaying the topics of a talk but to display the talks of a topic. Given the filter introduce in #433 we can now display within a turbo frame the talks of a topics and we could extend that to speaker#show page and event#show page. That would DRY quite a bit the rendering of talks card. |
1c5ffa4
to
78b8ce0
Compare
ok I wen't much further :
The benefits I see is to dry a bit that part of the views and when we start adding filters, sorting etc that can be added globaly to all views |
1fbfe14
to
a526076
Compare
a526076
to
bf01f6e
Compare
16daef0
to
4327179
Compare
for now I would like to test this only for admin to play a bit with it to be sure they are no side effects.