Extract enhancer jobs to a speaker associated object #466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcoroth
reviewed
Nov 29, 2024
There was a problem hiding this comment.
Yes, this is great! I like the two gems as well and think this is a great way to refactor this 🙌🏼
When you port over the GitHub enhancement job, I think we should remove the search_github_profile method, or at least update it so it only uses the matching profile if it found exactly one.
|
Hell yes, thanks for using these! ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I like quite a lot the associated object pattern combined with the performs gem.
This is a WIP that extract the Bsky enhancer job to an Speaker::ProfileEnhancer associated object
I personnaly like how we can :
speaker.profile_enhancer.enhance_all_later!not tested yet and the Github part is missing just for now a POC to see how it could look like