-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Burger menu #47
base: main
Are you sure you want to change the base?
Burger menu #47
Conversation
@@ -0,0 +1,26 @@ | |||
document.addEventListener('turbo:load', function () { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
at this point this is just vanilla js stored in a folder for stimulus controllers.
why don't you use an actual stimulus controller? :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great point! I am new to stimulus but I should follow the convention. I will work on it sometime this week. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hello @awalsh3 thanks for taking this issue.
I would like to suggest an alternative path at the same time with less JS or maybe none. the details/summary html tags can be used to create dropdowns. This is What Basecamp uses in Hey as an example
Here is an article on that subject but they are also several others available :
https://dev.to/ayushn21/details-summary-tags-html-s-best-kept-secret-4ak4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I mentioned Basecamp/Hey it was more for the technical part not really the way it looks. Your personal site looks clean I am sure you can make a good judgement on what looks best. I don't have a very strong option on this.
ISSUE: #6
This proposed PR adds a burger menu with drop-down links for mobile rendering. This uses tailwind css and plain vanilla javascript.
A few questions/notes:
A start for now! Please let me know what can be improved.
Photos below: