Allow Talk to have child/embedded talks
#474
Merged
+8,141
−1,847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcoroth
changed the title
Talk to have child/embedded talks
|
Updated the section below the talk to only show the first 4 talks
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #157
This pull request allows a recording/video to have multiple talks. These embeded talks get treated as regular talks throughout the app which makes it also easier to find and watch them.
Additionally it adds
start_secondsandend_secondscolumns to the talk model so talks can be started at the right moment within the recording.In a follow up PR it would be nice to make it so it automatically switches over the segments as the video playing. Or if you click on a segment that it just seeks to the seconds instead of reloading the player by doing a regular visit.