Store github_metadata to serve avatar using avatar_url
#480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcoroth
force-pushed
the
github-metadata
branch
from
ab40bbf to
a4c50a6
Compare
marcoroth
changed the title
github_metadata on Speaker to serve avatar using avatar_urlgithub_metadata to serve avatar using avatar_url
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull_requests adds a
github_metadatato theSpeakermodel so we can store the direct-linkavatar_urlfor the speakers.The current approach of using
https://github.com/[username].pngis always doing a redirect which sometimes wouldn't resolve. This makes it more reliable since we don't have to depend on the redirect to happen.Resolves #330