Fix "Peer refused to agree to our IP address" #1021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I do not understand ipcp-accept-local would be required or have any effect here: With this option, pppd will accept the peer's idea of our local IP address, even if the local IP address was specified in an option. Indeed, we do not specify the local IP address: ":169.254.2.1", // <local_IP_address>:<remote_IP_address> Instead, we explicitly ask the peer to provide the local IP address, using option noipdefault: With this option, the peer will have to supply the local IP address during IPCP negotiation (unless it specified explicitly on the command line or in an options file). It seems to be working in practice. So let's test it.
|
I guess it might help when a local IP address is defined in |
|
I am observing this with openfortivpn 1.20.3 in NixOS and pppd 2.5.0. Is that a combination that should work? |
|
Doesn't it work? |
|
No, unfortunately it doesn't |
|
Well, what's the problem, and does this new patch fix the problem? |
|
Oh, my bad, for some reason I assumed that 1.10.3 contained all patches already! Will try |
|
Indeed, on master it works for me as well! |
|
I have fixed it #1076 (comment) |
Repository owner
deleted a comment from
Neustradamus
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I do not understand why
ipcp-accept-localwould be required or have any effect here:Indeed, we do not specify the local IP address:
Instead, we explicitly ask the peer to provide the local IP address, using option
noipdefault:It seems to be working in practice. So let's test it.
Fixes #920.