Skip resolvectl for now

[DimitriPapadopoulos]

On Fedora resolvectl does not work as expected when invoked as resolvconf.
Also the exit status is not 0 so the current test never works actually:

$ resolvconf -a -f ; echo $?
Expected interface name as argument.
1
$ 

I suggest this goes in openfortivpn 1.13.2.

[DimitriPapadopoulos]

Instead implement #590.

Hopefully we will have some input from:
https://bugzilla.redhat.com/show_bug.cgi?id=1815605

[mrbaseman]

The intention actually was to catch this return value of 1. If resolvctl works as described in the man page it should support the -f option when called es resolvconf and silently ignore a missing interface. If it does not work properly, we should not use it.

But maybe I have misunderstood this sentence. Maybe "missing interface" means an interface name supplied to the call, but not describing an existing interface.

[DimitriPapadopoulos]

Let me detail what happens on Fedora:

I may be wrong but I had understood that you were expecting the exit status of resolvconf -a -f to be 0 based on the resolvectl(1) man page. I would not necessarily interpret "will silently execute no operation" as meaning that the exit status is 0, just that no message is written to the terminal. In any case both assumptions are wrong without an interface name passed as an argument to -a: an error message is written to the terminal and the exist status is 1:

$ sudo resolvconf -a -f ; echo $?
Expected interface name as argument.
1
$ 
$ sudo resolvconf -d -f ; echo $?
Expected interface name as argument.
1
$ 

Unless I am missing something, the existing test attempts to catch an exit status of 0, not an exit status of 1, doesn't it?

Finally invoking resolvectl as resolvconf in "real life" doesn't seem to be working either, at least on Fedora, see:
https://bugzilla.redhat.com/show_bug.cgi?id=1815605

Running this as root on Fedora 31:

$ cat /etc/resolv.conf 
# Generated by NetworkManager
nameserver 10.0.2.3
$ 
$ cat MY_FILE 
namsserver 1.1.1.1
nameserver 1.0.0.1
$ 
$ cat MY_FILE | /usr/sbin/resolvconf -a enp0s3 -f ; echo $?
0
$ 
$ cat /etc/resolv.conf 
# Generated by NetworkManager
nameserver 10.0.2.3
$ 
$ cat MY_FILE | /usr/sbin/resolvconf -a enp0s3 ; echo $?
0
$ 
$ cat /etc/resolv.conf 
# Generated by NetworkManager
nameserver 10.0.2.3
$ 

[DimitriPapadopoulos]

Ah, the exit status is 0 when using a fake interface name with -f - but of course not without -f:

$ /usr/sbin/resolvconf -a foobar -f ; echo $?
0
$ 
$ usr/sbin/resolvconf -a foobar; echo $?
Unknown interface 'foobar': No such device
1
$ 

That doesn't change the fact that invoking ressolvectl as resolvconf does not seem to be working.

[mrbaseman]

Based on the discussion I agree to skip the resolvectl case here. It does not work as expected and the configure test does not even catch the case that I was trying to address with it.