Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added "from_r0" to Burkert potential #370

Merged
merged 6 commits into from
Aug 22, 2024
Merged

Added "from_r0" to Burkert potential #370

merged 6 commits into from
Aug 22, 2024

Conversation

HSouch
Copy link
Contributor

@HSouch HSouch commented Mar 29, 2024

Added a method to generate the Burkert potential from just the r0

This is standard practice, as it is ultimately a 1-parameter potential. The relationship between density and core radius is described in Equations 4 and 5 of Mori & Burkert 2000.

Checklist

  • Did you add tests?
  • Did you add documentation for your changes?
  • Did you reference any relevant issues?
  • Did you add a changelog entry? (see CHANGES.rst)
  • Are the CI tests passing?
  • Is the milestone set?

@adrn
Copy link
Owner

adrn commented Aug 22, 2024

Sorry for the long delay! I rebased your PR, so pull locally before you make any additional changes. I left one suggested change and one comment on the implementation. Thanks!

@adrn adrn merged commit 8ed7b81 into adrn:main Aug 22, 2024
17 checks passed
@adrn
Copy link
Owner

adrn commented Aug 22, 2024

Thanks @HSouch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants