Merge pull request #288 from mugdhapolimera/publisheredit

Publisher field assigned for records with metadata from multiple sources
adsabs · Feb 8, 2024 · fdc613f · fdc613f
2 parents e13f0f5 + 1e60945
commit fdc613f
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 2 deletions.
diff --git a/aip/classic/merger.py b/aip/classic/merger.py
@@ -189,6 +189,7 @@ def publicationMerger(self,field):
         'electronic_id':  i['publication']['electronic_id'],
         'name':           i['publication']['name'],
         'dates':          i['publication']['dates'],
+        'publisher':      i['publication']['publisher'],
       },i['tempdata']) for i in self.blocks if not i['tempdata']['alternate_journal'] ]
 
     altpublications = [{
@@ -204,6 +205,7 @@ def publicationMerger(self,field):
         'electronic_id':  i['publication']['electronic_id'],
         'name':           i['publication']['name'],
         'dates':          i['publication']['dates'],
+        'publisher':      i['publication']['publisher'],
     } for i in self.blocks if i['tempdata']['alternate_journal'] ]
 
     self.altpublications = altpublications

diff --git a/aip/classic/solr_adapter.py b/aip/classic/solr_adapter.py
@@ -5,7 +5,6 @@
 import re
 import traceback
 import datetime
-
 from adsputils import get_date, date2solrstamp
 from aip.classic import enforce_schema
 

diff --git a/tests/classic/test_solr_adapter.py b/tests/classic/test_solr_adapter.py
@@ -64,7 +64,7 @@ def test_SolrAdapter(self):
          'publisher': u'test-Publisher',
          'title': [u'This is of the title', u'This is of the alternate'],
          'volume': u'l24'})
-    
+
         r = solr_adapter.SolrAdapter.adapt(ADSRECORDS['testbibcode2'])
         solr_adapter.SolrAdapter.validate(r) #Raises AssertionError if not validated
         self.assertEquals(r, {

diff --git a/tests/stubdata/ADSRecords/2015ApJ...815..133S b/tests/stubdata/ADSRecords/2015ApJ...815..133S
@@ -79,6 +79,7 @@
                                'page_last': None,
                                'page_range': None,
                                'volume': u'815',
+                               'publisher': u'IOP',
 			       'series': u'123'},
                'pubnote': [],
                'tempdata': {'alternate_journal': False,
@@ -130,6 +131,7 @@
                                'page_last': None,
                                'page_range': None,
                                'volume': u'815',
+                               'publisher': u'Publisher',
 			       'series': u'123'},
                'pubnote': [],
                'tempdata': {'alternate_journal': False,
@@ -715,6 +717,7 @@
                                'page_last': None,
                                'page_range': None,
                                'volume': None,
+                               'publisher': u'Publisher',
 			       'series': u'123'},
                'pubnote': [OrderedDict([(u'@origin', u'ARXIV'), ('content', u'33 pages, 7 figures, 5 tables, ApJ in press; doi:10.1088/0004-637X/815/2/133')])],
                'tempdata': {'alternate_journal': True,

diff --git a/tests/stubdata/mergerdata.py b/tests/stubdata/mergerdata.py
@@ -515,5 +515,6 @@
          'pubnote': [u'33 pages, 7 figures, 5 tables, ApJ in press; doi:10.1088/0004-637X/815/2/133'],
          'title': [u'Ultraviolet Radiative Transfer Modeling of Nearby Galaxies with Extraplanar Dusts'],
          'volume': u'815',
+         'publisher': u'IOP',
          'series': '123',
          'year': u'2015'}