Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GA4 Updates #2283

Merged
merged 3 commits into from
Feb 5, 2024
Merged

GA4 Updates #2283

merged 3 commits into from
Feb 5, 2024

Commits on Feb 1, 2024

  1. add proper GTM tag

    @thostetler
    thostetler committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    06d451e View commit details
    Browse the repository at this point in the history

Commits on Feb 5, 2024

  1. fix up analytics calls where necessary

    @thostetler
    thostetler committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    e1b3815 View commit details
    Browse the repository at this point in the history

  2. Fix/Update test 

    Removing the analytics test for now.  This test was mainly used to make
sure the array was properly pushed to, and that it does the right thing
if the global is undefined.  I think this module is simple enough to
leave as a proxy to the GTM call.  We can add more testing for the
logger in the future.
    @thostetler
    thostetler committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    067e216 View commit details
    Browse the repository at this point in the history