Merge pull request #17 from seasidesparrow/main

fix: alters key names in contrib to use underscore in place of hyphen
adsabs · May 18, 2023 · c051245 · c051245
2 parents 94e2042 + 01916dd
commit c051245
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 10 deletions.
diff --git a/adsingestschema/Contrib.json b/adsingestschema/Contrib.json
@@ -9,10 +9,10 @@
         "surname": {
           "type": "string"
         },
-        "given-name": {
+        "given_name": {
           "type": "string"
         },
-        "middle-name": {
+        "middle_name": {
           "type": "string"
         },
         "prefix": {
@@ -24,7 +24,7 @@
         "pubraw": {
           "type": "string"
         },
-        "native-lang": {
+        "native_lang": {
           "type": "string"
         },
         "collab": {

diff --git a/adsingestschema/__init__.py b/adsingestschema/__init__.py
@@ -12,4 +12,4 @@ def ads_schema_validator():
 
     validator = Draft7Validator(schema=schema, resolver=resolver)
 
-    return validator
+    return validator
diff --git a/test_data/gcnc.json b/test_data/gcnc.json
@@ -17,7 +17,7 @@
     {
       "name": {
         "surname": "Kruehler",
-        "given-name": "T."
+        "given_name": "T."
       },
       "affiliation": [
         {
@@ -28,7 +28,7 @@
     {
       "name": {
         "surname": "Greiner",
-        "given-name": "J."
+        "given_name": "J."
       },
       "affiliation": [
         {
@@ -39,7 +39,7 @@
     {
       "name": {
         "surname": "Kann",
-        "given-name": "D.A."
+        "given_name": "D.A."
       },
       "affiliation": [
         {

diff --git a/test_data/gcnc_fails.json b/test_data/gcnc_fails.json
@@ -17,7 +17,7 @@
     {
       "name": {
         "surname": "Kruehler",
-        "given-name": "T."
+        "given_name": "T."
       },
       "affiliation": [
         {
@@ -28,7 +28,7 @@
     {
       "name": {
         "surname": "Greiner",
-        "given-name": "J."
+        "given_name": "J."
       },
       "affiliation": [
         {
@@ -39,7 +39,7 @@
     {
       "name": {
         "surname": "Kann",
-        "given-name": "D.A."
+        "given_name": "D.A."
       },
       "affiliation": [
         {