Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Python3 compatibility #13

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Add Python3 compatibility #13

wants to merge 4 commits into from

Conversation

goanpeca
Copy link

So I needed to track some analytics and this library seemed to work fine except the python3 issue.

I added python3 compatibility using six, fixed the tests to run on py3 as well and fixed the code to be pep8 compliant.

I am using this in my fork now, but left this here in case the project is still supported.

Cheers

@goanpeca
Copy link
Author

@samba any chance of getting this merged?

@samba
Copy link
Contributor

samba commented Apr 15, 2016

@goanpeca Sorry for the late follow up.
This project is maintained by Analytics Pros, my former employer. I've contacted them to consider merging these changes, as they retain ownership and privileges to accept merges on this repository.

Thank you for this contribution, and remedying my lack of PEP-8 in the original authorship :) By visual inspection I believe the changes are sound, so I'll encourage Analytics Pros to merge these at their earliest opportunity.

@goanpeca
Copy link
Author

@samba, 👍

@goanpeca
Copy link
Author

@LukaData now this has conflicts, should I fix or just close the PR?

@lukaszbanasiak
Copy link

@goanpeca can you provide commit to this PR with resolved conflict?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants