-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Python3 compatibility #13
base: master
Are you sure you want to change the base?
Conversation
@samba any chance of getting this merged? |
@goanpeca Sorry for the late follow up. Thank you for this contribution, and remedying my lack of PEP-8 in the original authorship :) By visual inspection I believe the changes are sound, so I'll encourage Analytics Pros to merge these at their earliest opportunity. |
@samba, 👍 |
@LukaData now this has conflicts, should I fix or just close the PR? |
@goanpeca can you provide commit to this PR with resolved conflict? |
So I needed to track some analytics and this library seemed to work fine except the python3 issue.
I added python3 compatibility using six, fixed the tests to run on py3 as well and fixed the code to be pep8 compliant.
I am using this in my fork now, but left this here in case the project is still supported.
Cheers