Update Dependencies, fix type errors, and general improvements. #693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we were misusing Vite's `import.meta.env.DEV` and `vite --mode` modes to configure the web runtime build as either the game development build, or the slim build for releasing games. This is not the intended use for those variables. They are meant for discerning between developing/debugging or production builds of the wasm4 runtime itself. You can read more about those variables here: https://vitejs.dev/guide/env-and-mode.html In particular, updating to Vite 5 broke the wasm4 web-devtools because of this. This commit instead introduces a new environment variable VITE_WASM4_GAMEDEV_MODE to configure the build. It is loaded into the constant `constant.GAMEDEV_MODE`. I also removed `constant.DEBUG` because it didn't seem to do anything useful.
Change `npm --prefix '../../devtools/web' install` to a normal script rather than a prepare script, so that it doesn't get run pointlessly during installs like before. (which is too late to do anything useful anyway.) Also, use `cd` instead of `--prefix` for simplicity and clarity.
This is reccomended by the vite docs here: https://vitejs.dev/guide/features#typescript-compiler-options In the future we should also consider changing our target and useDefineForClassFields settings, as explained in the link above and also in this esbuild link: https://esbuild.github.io/content-types/#tsconfig-json
|
This is amazing, thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I updated the dependencies, most notably Vite to version 5. I also reviewed how Vite was being configured and fixed development builds being used in production.
I also fixed several typescript issues, the code now passes type-checking.
There are also various other little tidy-ups and improvements.