fix retroarch core running too fast under certain conditions #746
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had an issue on my rg35xxsp with latest muos cfw test build. Where retroarch reported games running at about 120 fps with vsync on this made the games run twice as fast. i was able to fix it when testing by making the destination buffer a global and only calling video_cb once at the end of retro_run this makes sure that
video_cb(destframe, 160, 160, ...
is only ever called really once per frame. My guess is that it was potentially being called multiple times per frame in my case.Now when i ran the core on my rg35xxsp it showed correctly 60 fps in the fps counter and games did not run twice as fast anymore.
It was also really noticeable while running the core with vsync off, on my rg35xxsp retroarch was reporting 1200 fps and the games were running equally fast then but with this change vsync on or off it was running always at 60 fps
I had heared on discord this may have been a known issue or was reported at least once. I do not know if this fix is valid but at least for me it fixed it