IMU covariance using Euler packet #14
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 7, 2025 13:41
Original decoder used quaternion standard deviation elements Q0, Q1, and Q2 directly as covariances around the x, y, and z axes in the IMU message. This doesn't seem like a valid way to interpret these values. Euler standard deviation converted into covariance has replaced this to give better values in the IMU message covariance matrix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The driver was using 3 out of 4 quaternion standard deviation values and populating the ROS2 IMU message orientation covariance matrix with them.
This covariance matrix is intended to be row major about the x, y, and z axes as detailed here:
https://docs.ros2.org/foxy/api/sensor_msgs/msg/Imu.html
As such, I'm not sure it is valid to populate this matrix with standard deviation values from a quaternion. I think a more representative value can be obtained by using ANPP 26, euler standard deviation, and converting it to covariance.
I have replaced the ANPP 27 decoder instead of adding the ANPP 26 decoder because ANPP 27 doesn't seem as usable for the message types included in this driver.