Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove admin routes from mydevice routes #36

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove admin routes from mydevice routes #36

wants to merge 1 commit into from

Conversation

simao
Copy link
Contributor

@simao simao commented Mar 6, 2017

No description provided.

@simao simao requested a review from jerrytrieu March 6, 2017 12:54
jerrytrieu
jerrytrieu approved these changes Mar 13, 2017
View reviewed changes
src/main/scala/com/advancedtelematic/treehub/http/ObjectResource.scala Outdated
case _ => ()
}
.map(_._2)
(get & optionalHeaderValueByName("x-ats-authorization")) { header ⇒
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra indent.

@simao simao force-pushed the separate_admin_device_routes_ branch from 791fd2a to e8bdcbd Compare March 13, 2017 14:48
@houcros
Copy link
Contributor

houcros commented Oct 24, 2019 •
edited
Loading

Do we still need this? Should we continue with it and merge it or close it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerrytrieu jerrytrieu jerrytrieu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@simao @houcros @jerrytrieu @atsjenkins