fix: divide by zero now does not crash #33
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
Thank you for this library.
Bug Fix: Division by Zero
I have identified a runtime crash issue caused by division by zero. For instance, the following code snippet causes the library to crash:
This pull request implements a fix to prevent this crash.
Additional Observations
There are similar crashes when operands are null. For example:
This likely happens because
null
is treated aszero
.or
andnull
:This is a valid expression and returns
true
:and
andnull
:However, this expression returns
nil
:It would be beneficial to handle nullable operands more predictably.
Thank you for your time reviewing this pull request.
Best regards,
Alexandre