Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move template description to template selection #564

Closed
selmiak opened this issue Dec 30, 2018 · 8 comments
Closed

move template description to template selection #564

selmiak opened this issue Dec 30, 2018 · 8 comments
Labels
context: ui/ux type: enhancement a suggestion or necessity to have something improved what: editor related to the game editor

Comments

@selmiak
Copy link
Contributor

selmiak commented Dec 30, 2018

and not after selecting the template.

@ivan-mogilko ivan-mogilko added what: editor related to the game editor res: in consideration labels Dec 30, 2018
@ghost
Copy link

ghost commented Jan 20, 2019

IIRC this means: display the description in the "select game template" window e.g. in a scrolling textbox, instead of displaying it after game is already created as a popup dialog.

This would require to preload template data, but I believe it's worth it because it's more convenient to get info about template's contents beforehand.

@ivan-mogilko ivan-mogilko added type: enhancement a suggestion or necessity to have something improved context: ui/ux and removed res: in consideration labels Sep 28, 2019
@jumpjack
Copy link

IIRC this means: display the description in the "select game template" window e.g. in a scrolling textbox

I think a 2-3 lines description inside a static label would be enough.

This would require to preload template data

Probably it would be easier and faster to just hardcode the descriptions inside the editor and associate them to templates names.

@ivan-mogilko
Copy link
Contributor

ivan-mogilko commented Jan 20, 2023

Probably it would be easier and faster to just hardcode the descriptions inside the editor and associate them to templates names.

Of course not! The templates are not hardcoded, and users may also create and distribute custom game templates.

I think a 2-3 lines description inside a static label would be enough.

The description comes from template, so we should not limit to N lines, but be ready to display whatever comes from template data.
EDIT: we may of course introduce a memory limit, to avoid problems if the text is too long for some weird reason.

@jumpjack
Copy link

I was talking only about templates distributed with AGS releases, I didn't even know it was possible to add custom templates.

@ivan-mogilko
Copy link
Contributor

ivan-mogilko commented Jan 21, 2023

The template file in AGS is simply an archive containing game files. When the game is created the Editor unpacks the archive into the destination folder. Technically, there's no difference between "standard" and custom user's templates.

The template's description is at the moment supplied as a template.txt file. Right now, Editor will load text from that file after whole template is unpacked into the new game, and display on popup.

For implementing a preview, Editor would need to read just that one file from each found template (archive) instead, and "give" these texts to the template selection dialog. That's a relatively simple operation, and will cover all cases.

@ericoporto
Copy link
Member

This was fixed in ags4 by #1903, can be labeled as ags4 and closed.

@ivan-mogilko
Copy link
Contributor

ivan-mogilko commented Mar 20, 2023

Weird, "Resolves" line did not work in pr.

Implemented in ags4 for now.

@ericoporto
Copy link
Member

Descriptions have been adjusted in adventuregamestudio/ags-template-source#69 and the UI has been backported to AGS 3.6.2 too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
context: ui/ux type: enhancement a suggestion or necessity to have something improved what: editor related to the game editor
Projects
None yet
Development

No branches or pull requests

4 participants