Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport Editor Template info preview #2574

Conversation

ericoporto
Copy link
Member

This was the PR #1903 , which fixed the issue #564 in AGS 4.

image

I wanted to backport it to ags3 as I really like it. I also wanted to fix a small annoyance I had with the change of the wizard dialog height, I tried to keep it the same, which is my last commit. I also did some small uses of layout in it using table and some docking.

@ivan-mogilko
Copy link
Contributor

Is this size adjustment because of the first page with the image? Something has to be done with it, maybe it can be scaled dynamically, replaced with another image, or completely redone into a form that is easier to scale.

@ivan-mogilko
Copy link
Contributor

I tested this, and something is off with text layout.

On the first page the text is now moved to the right, occupying maybe rightmost half of the blank space.

game-wizard-layout

On next pages, the title texts are moved further right and closer to the bottom of a white space, and have greater spacing between the lines. I cannot tell why was this necessary.

game-wizard-layout2

@ericoporto
Copy link
Member Author

Uhm, I didn't notice those changes, I will fix those.

What I actually want to get is use more of Layouts (for safe scaling) but try to keep as close as the current Wizard as possible.

Is this size adjustment because of the first page with the image?

Yeah, I don't like the blank part, but at the same time for that image specifically I can't think of a way to make it dynamically adjust. I am still understanding how the dialog panel actually gets the wizard pages in - layout wise.

@ivan-mogilko
Copy link
Contributor

Yeah, I don't like the blank part, but at the same time for that image specifically I can't think of a way to make it dynamically adjust.

I think it's worth opening a separate issue for this, and maybe ask on forums for help.
In the past I've changed the splash window from a single fixed image to dynamically constructed image with an icon in the middle, following an advice from the forum members.

@ericoporto ericoporto force-pushed the backport-editor-templateinfopreview branch from 202024d to 0934110 Compare November 12, 2024 13:58
@ericoporto ericoporto force-pushed the backport-editor-templateinfopreview branch from 0934110 to caaa509 Compare November 12, 2024 13:59
@ivan-mogilko ivan-mogilko merged commit 74e4448 into adventuregamestudio:master Nov 12, 2024
21 checks passed
@ericoporto ericoporto deleted the backport-editor-templateinfopreview branch November 12, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants