Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android project sdk upgrade and ci adjustments #2118

Conversation

ericoporto
Copy link
Member

@ericoporto ericoporto commented Aug 30, 2023

  • upgrade SDK build tools to 34.0.0
  • upgrade Android Gradle Plugin to 8.1.1 client, and upgrade Gradle to 8.3
  • better caching for android builds and configs, and in CI too (fine cache only pushes in master branch)
  • additional gradle properties tuning

@ericoporto ericoporto changed the title ci: no gradle daemon in android builds ci: fixes Android builds failing Aug 30, 2023
@ericoporto ericoporto force-pushed the ci-remove-gradle-daemon-in-android-builds branch 2 times, most recently from 6cb2ec4 to 6473473 Compare August 30, 2023 21:05
@ericoporto
Copy link
Member Author

ericoporto commented Sep 1, 2023

@ivan-mogilko I force pushed #2064 as an example, but Cirrus CI people have figured the issue and fixed on their side! So the android build is working again! (at least it worked in my fork, let's see if it works here too)

This PR is NOT necessary for making the CI build again!

I reworked the commits here as I think the summary of this - upgrade docker image, upgrade version of things and all that - is still valid and useful.

@ericoporto ericoporto force-pushed the ci-remove-gradle-daemon-in-android-builds branch 5 times, most recently from 477c7eb to 395b417 Compare September 1, 2023 02:44
NDK version is set to 25.2.9519653
Compile also with SDK 34
@ericoporto ericoporto force-pushed the ci-remove-gradle-daemon-in-android-builds branch 5 times, most recently from 54e6657 to fe9e68e Compare September 1, 2023 02:56
@ericoporto ericoporto force-pushed the ci-remove-gradle-daemon-in-android-builds branch from fe9e68e to 112554f Compare September 1, 2023 02:58
Use Android Studio Gradle Plugin client in 8.1.1 along
@ericoporto ericoporto force-pushed the ci-remove-gradle-daemon-in-android-builds branch 2 times, most recently from 3681d24 to 683e486 Compare September 1, 2023 03:02
- cache build and config
- try maven central before google repositories
- let gradle use more memory
- adjust gradle timeouts (daemon and connections)
@ericoporto ericoporto force-pushed the ci-remove-gradle-daemon-in-android-builds branch from 683e486 to 5aaf5b8 Compare September 1, 2023 03:08
@ericoporto ericoporto changed the title ci: fixes Android builds failing Android project sdk upgrade and ci adjustments Sep 1, 2023
@ericoporto ericoporto force-pushed the ci-remove-gradle-daemon-in-android-builds branch from 5aaf5b8 to 88313a2 Compare September 1, 2023 13:26
@ericoporto ericoporto marked this pull request as ready for review September 1, 2023 14:18
@ivan-mogilko ivan-mogilko merged commit 9bb05f4 into adventuregamestudio:master Sep 1, 2023
@ericoporto ericoporto deleted the ci-remove-gradle-daemon-in-android-builds branch September 1, 2023 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants