Improper log output when using GitHub Status Notifications in spinnaker
Moderate severity
GitHub Reviewed
Published
Aug 28, 2023
in
spinnaker/spinnaker
•
Updated Nov 6, 2023
Package
Affected versions
< 1.28.8
>= 1.29.0, < 1.29.6
>= 1.30.0, < 1.30.3
>= 1.31.0, < 1.31.1
Patched versions
None
Description
Published by the National Vulnerability Database
Aug 28, 2023
Published to the GitHub Advisory Database
Aug 29, 2023
Reviewed
Aug 29, 2023
Last updated
Nov 6, 2023
Impact
ONLY IMPACTS those use GitHub Status Notifications
Log output when updating GitHub status is improperly set to FULL always. It's recommended to apply the patch and rotate the GitHub token used for github status notifications. Given that this would output github tokens to a log system, the risk is slightly higher than a "low" since token exposure could grant elevated access to repositories outside of control. If using READ restricted tokens, the exposure is such that the token itself could be used to access resources otherwise restricted from reads.
Patches
Patch is in progress. spinnaker/echo#1316
Workarounds
Disable GH Status Notifications. Filter your logs for Echo log data. Use read-only tokens that are limited in scope.
References
sig-security in slack: https://spinnakerteam.slack.com/archives/CFN8F5UR2
References