Skip to content

Improper log output when using GitHub Status Notifications in spinnaker

Moderate severity GitHub Reviewed Published Aug 28, 2023 in spinnaker/spinnaker • Updated Nov 6, 2023

Package

gomod github.com/spinnaker/spinnaker (Go)

Affected versions

< 1.28.8
>= 1.29.0, < 1.29.6
>= 1.30.0, < 1.30.3
>= 1.31.0, < 1.31.1

Patched versions

None

Description

Impact

ONLY IMPACTS those use GitHub Status Notifications

Log output when updating GitHub status is improperly set to FULL always. It's recommended to apply the patch and rotate the GitHub token used for github status notifications. Given that this would output github tokens to a log system, the risk is slightly higher than a "low" since token exposure could grant elevated access to repositories outside of control. If using READ restricted tokens, the exposure is such that the token itself could be used to access resources otherwise restricted from reads.

Patches

Patch is in progress. spinnaker/echo#1316

Workarounds

Disable GH Status Notifications. Filter your logs for Echo log data. Use read-only tokens that are limited in scope.

References

sig-security in slack: https://spinnakerteam.slack.com/archives/CFN8F5UR2

References

@jasonmcintosh jasonmcintosh published to spinnaker/spinnaker Aug 28, 2023
Published by the National Vulnerability Database Aug 28, 2023
Published to the GitHub Advisory Database Aug 29, 2023
Reviewed Aug 29, 2023
Last updated Nov 6, 2023

Severity

Moderate

CVSS overall score

This score calculates overall vulnerability severity from 0 to 10 and is based on the Common Vulnerability Scoring System (CVSS).
/ 10

CVSS v3 base metrics

Attack vector
Physical
Attack complexity
Low
Privileges required
None
User interaction
None
Scope
Changed
Confidentiality
Low
Integrity
Low
Availability
None

CVSS v3 base metrics

Attack vector: More severe the more the remote (logically and physically) an attacker can be in order to exploit the vulnerability.
Attack complexity: More severe for the least complex attacks.
Privileges required: More severe if no privileges are required.
User interaction: More severe when no user interaction is required.
Scope: More severe when a scope change occurs, e.g. one vulnerable component impacts resources in components beyond its security scope.
Confidentiality: More severe when loss of data confidentiality is highest, measuring the level of data access available to an unauthorized user.
Integrity: More severe when loss of data integrity is the highest, measuring the consequence of data modification possible by an unauthorized user.
Availability: More severe when the loss of impacted component availability is highest.
CVSS:3.1/AV:P/AC:L/PR:N/UI:N/S:C/C:L/I:L/A:N

EPSS score

0.068%
(32nd percentile)

Weaknesses

CVE ID

CVE-2023-39348

GHSA ID

GHSA-rq5c-hvw6-8pr7

Source code

Loading Checking history
See something to contribute? Suggest improvements for this vulnerability.