Fix:Updating root user #3366

advplyr · Sep 2, 2024 · 60e348f · 60e348f
1 parent f194c5b
commit 60e348f
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/server/controllers/UserController.js b/server/controllers/UserController.js
@@ -205,9 +205,12 @@ class UserController {
   async update(req, res) {
     const user = req.reqUser
 
-    if (user.type === 'root' && !req.user.isRoot) {
+    if (user.isRoot && !req.user.isRoot) {
       Logger.error(`[UserController] Admin user "${req.user.username}" attempted to update root user`)
       return res.sendStatus(403)
+    } else if (user.isRoot) {
+      // Root user cannot update type
+      delete req.body.type
     }
 
     const updatePayload = req.body