Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config page for all RSS feeds #2026

Merged
merged 3 commits into from
Aug 22, 2023

Conversation

shawnphoffman
Copy link
Contributor

@shawnphoffman shawnphoffman commented Aug 22, 2023

Overview

I tend to lose track of what RSS feeds I have open so I decided to add a config screen for them. Basically, it just lists all of the open RSS feeds with some basic metadata and a button to close them. A modal lists the episodes associated with the feed and copy-to-clipboard option.

Discussion: #2014

Open Questions

  • Localization. Is there a process for this? Do we leave the keys out of the JSON files or include them with English strings?

Screenshots

Full-width Narrow view View feeds modal Close feed confirmation

@advplyr
Copy link
Owner

advplyr commented Aug 22, 2023

Thanks, this is a good idea. For localization just updating the en-us.json file is perfect. At some point a more scalable localization solution will be put in place but for now I just run a script that adds the English strings to all the other json files.

@advplyr advplyr merged commit ec15978 into advplyr:master Aug 22, 2023
1 check passed
@shawnphoffman shawnphoffman deleted the shawn/rss-feeds branch August 29, 2023 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants