Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for allowing backups of unlimited size #3163

Merged
merged 4 commits into from
Jul 17, 2024

Conversation

ajyey
Copy link
Contributor

@ajyey ajyey commented Jul 16, 2024

This MR adds support for allowing backups of unlimited size (denoted by 0).

Addresses #3157

@ajyey ajyey requested a review from nichwall July 16, 2024 05:31
Copy link
Contributor

@nichwall nichwall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I put some random large files in /metadata/items (so my backups were about 7 GB) and everything is working as expected with both unlimited and maximum size set.
A new server did also correctly set the default maximum size to 1 GB.

@advplyr
Copy link
Owner

advplyr commented Jul 17, 2024

Thanks!

@advplyr advplyr merged commit 03be947 into advplyr:master Jul 17, 2024
5 checks passed
@ZLoth
Copy link

ZLoth commented Jul 21, 2024

Thank you!

@ajyey ajyey deleted the feature/disable-max-backup-size branch August 2, 2024 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants