fix: switch account during comment loading indicator not shown (#1861)

src/features/auth/AccountSwitcher.tsx

@@ -21,6 +21,7 @@ import {
   ListEditorProvider,
 } from "#/features/shared/ListEditor";
 import { moveItem } from "#/helpers/array";
+import { isPromiseResolvedByPaint } from "#/helpers/promise";
 import { useAppDispatch, useAppSelector } from "#/store";
 
 import Account from "./Account";
@@ -29,7 +30,7 @@ import { setAccounts } from "./authSlice";
 
 type AccountSwitcherProps = {
   onDismiss: (data?: string, role?: string) => void;
-  onSelectAccount: (account: string) => Promise<void> | void;
+  onSelectAccount: (account: string) => Promise<void>;
   showGuest?: boolean;
   activeHandle?: string;
 } & (
@@ -131,7 +132,8 @@ function AccountSwitcherContents({
 
               const selectionChangePromise = onSelectAccount(e.target.value);
 
-              if (!selectionChangePromise) {
+              // Bail on rendering the loading indicator
+              if (await isPromiseResolvedByPaint(selectionChangePromise)) {
                 onDismiss();
                 return;
               }

src/features/shared/markdown/editing/modal/contents/TemporarySelectedAccountContext.tsx

@@ -60,7 +60,7 @@ export function TemporarySelectedAccountProvider({
       onDismiss: (data?: string, role?: string) =>
         onDismissAccountSwitcher(data, role),
       onSelectAccount: async (account: string) => {
-        onSelectAccount(account);
+        await onSelectAccount(account);
 
         setSelectedAccountHandle(account);
       },

src/helpers/promise.ts

@@ -0,0 +1,12 @@
+export function isPromiseResolvedByPaint(
+  promise: Promise<unknown>,
+): Promise<boolean> {
+  return Promise.race([
+    promise.then(() => true),
+    new Promise<false>((resolve) => {
+      requestAnimationFrame(() => {
+        resolve(false);
+      });
+    }),
+  ]);
+}