Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: collapse downvoted comments by default when setting (default off) is set #1860

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

jameslounds
Copy link

@jameslounds jameslounds commented Feb 21, 2025

Closes #1838

This is my first contribution, so it's very possible I've misunderstood something or not followed conventions in the project. As well as more substantive feedback, nitpicks are more than welcome - they help me learn!

About the `ppm-lcck.yaml` update (reverted)

Also not entirely sure why, but the pnpm-lock.yaml needed updating. pnpm i --frozen-lockfile gave an error

❯ pnpm i --frozen-lockfile
 ERR_PNPM_LOCKFILE_CONFIG_MISMATCH  Cannot proceed with the frozen installation. The current "patchedDependencies" configuration doesn't match the value found in the lockfile

Update your lockfile using "pnpm install --no-frozen-lockfile"

It seems that the CI won't pass with my updated lockfile (with the same error I get using the main lockfile).

The setting is off by default.

I've added hasUserCollapsed which is true if the value for commentId in state.comment.commentCollapsedById has been defined. If it hasn't we're in the initial state of the comment (uncollapsed unless downvoted & setting is set). If it has, the user must have shown/hidden the comment so we should use the state from state.comment.commentCollapsedById rather than the default.

@jameslounds jameslounds changed the title Feat: Collapse downvoted comments by default when setting (default off) is set feat: Collapse downvoted comments by default when setting (default off) is set Feb 21, 2025
This reverts commit c1b5630.
@jameslounds jameslounds changed the title feat: Collapse downvoted comments by default when setting (default off) is set feat: collapse downvoted comments by default when setting (default off) is set Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Auto hide downvoted comments
1 participant