Skip to content
This repository has been archived by the owner on Apr 28, 2020. It is now read-only.

Master #14

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Master #14

wants to merge 2 commits into from

Conversation

stagadet
Copy link

Added test configuration B
Added possibility for configuration B to use both GET and POST http requests for all commands
Added description of commands for:

  1. Power consumption
  2. Special modes
  3. WiFi LEDs
  4. Timers

stagadet added 2 commits December 11, 2016 18:33
Added test configuration B
Added possibility for configuration B to use both GET and POST http
requests for all commands
Added description of commands for:
1) Power consumption
2) Special modes
3) WiFi LEDs
4) Timers
@Apollon77
Copy link

One thought on the GET/POST topic: Even if Daikin implemented something that breaks REST "ideas" (e.g. using GET calls to change values) the question is if this should be used ... It's better to follow common standards for usage, or ?!

@stagadet
Copy link
Author

I don't know if it is better to use GET or POST to modify parameters in this case. The official Daikin app that I tested uses GET, while I think ael-code's GUI uses POST. In my case they both work, maybe also in older setups. In any case I think it is better to show both possibilities in the 'documentation'.

@Apollon77
Copy link

@ael-code I have an enhanced version of this pull request in my fork at https://github.com/Apollon77/daikin-control in an new file (just to be able to get updates from upstream without all those conflict stuff)
I also used your infos to implement an nodejs library (https://github.com/Apollon77/daikin-controller) and verified nearly all of those new details with this lib and my two daikin devices.

Maybe you can check my README_updated.md nd tell me what you see on change needs in preparation to make an official pull request ... Or should I just send it?
Would be great. Thank you for all you great work here

@WildRat
Copy link

WildRat commented Jan 6, 2018

Why this information still don't added in readme file? It's quite useful.

@andras-tim
Copy link

Please merge this PR, because I accidentally found the missing endpoints

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants