-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement TemplateStatefulSet function #278
Implement TemplateStatefulSet function #278
Conversation
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
f5f018b
to
8b5b903
Compare
8b5b903
to
9629e9f
Compare
This PR implements the
factory.TemplateStatefulSet
function. The templating was originally carried out as part of thefactory.CreateOrUpdateStatefulSet
function. Almost all of the templating is branchless and is mostly inlined inside of a struct literal. References to thePodTemplate
field of theEtcdCluster.Spec
struct were dropped, as premature features that for now only complicate the code, while being non-essential to operating an etcd cluster. When needed, parts of the statefulset template can be factored back out into separate helper functions, much like is already done in e.g.factory.volumes()
and the possibility of customizing the etcd pod with custom annotations, labels, sidecar containers, etc. can be restored.