fix(talm): skip over disks that don't have a wwid

[alexdor]

While spinning up new bare metal devices, there were a lot of loop devices present in the machine. Talm didn't detect a system disk and it used the first loop device as a target, causing talos installation to crash and reboot. This commit skips loop devices during the helm template causing the fallback to be the first non-loop device.

Summary by CodeRabbit

• Bug Fixes
  • Modified the logic for determining the system disk name, enhancing the accuracy of disk assignments based on specific conditions.

[coderabbitai]

Walkthrough

The pull request introduces a modification to the Helm chart's template helper for determining the system disk name. The change updates the condition for assigning a disk name, now requiring not only an empty initial disk value but also the presence of a .wwid field. This refinement adds an additional layer of validation when selecting the system disk in the Kubernetes deployment configuration.

Changes

File	Change Summary
charts/talm/templates/_helpers.tpl	Modified disk name assignment logic to require both an empty $disk and the presence of a .wwid field

Poem

🐰 A Helm chart's disk dance, so precise
Where empty strings and wwids entice
A template's logic, now more refined
Selecting disks with care designed
Code rabbit hops with glee so bright! 🚀

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5ea36dd and 8395c47.

📒 Files selected for processing (1)

• charts/talm/templates/_helpers.tpl (1 hunks)

🔇 Additional comments (1)

charts/talm/templates/_helpers.tpl (1)

4-4: Validate this additional .wwid check for completeness.

This updated condition ensures only the first disk with a .wwid is selected when $disk is still "". This helps skip disks lacking a WWID (e.g., loop devices) and aligns with the PR objective to avoid selecting loop devices incorrectly. However, confirm that there are no legitimate disks without WWIDs (for instance, certain virtual disks) that should still be prioritized. If such a scenario is possible, consider adding a fallback mechanism to handle disks without a WWID but which are valid for use.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.