Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Add DCNNNetwork #1576

Open
wants to merge 26 commits into
base: main
Choose a base branch
from
Open

[ENH] Add DCNNNetwork #1576

wants to merge 26 commits into from

Conversation

aadya940
Copy link
Contributor

Implement Dilated Convolutional Neural Network based Auto-Encoder.

@aeon-actions-bot aeon-actions-bot bot added enhancement New feature, improvement request or other non-bug code enhancement networks Networks package labels May 27, 2024
@aeon-actions-bot
Copy link
Contributor

Thank you for contributing to aeon

I have added the following labels to this PR based on the title: [ $\color{#FEF1BE}{\textsf{enhancement}}$ ].
I have added the following labels to this PR based on the changes made: [ $\color{#379E11}{\textsf{networks}}$ ]. Feel free to change these if they do not properly represent the PR.

The Checks tab will show the status of our automated tests. You can click on individual test runs in the tab or "Details" in the panel below to see more information if there is a failure.

If our pre-commit code quality check fails, any trivial fixes will automatically be pushed to your PR unless it is a draft.

Don't hesitate to ask questions on the aeon Slack channel if you have any.

Copy link
Contributor

@hadifawaz1999 hadifawaz1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good start, a few comments on the network

aeon/networks/_dcnn.py Show resolved Hide resolved
aeon/networks/_dcnn.py Outdated Show resolved Hide resolved
aeon/networks/_dcnn.py Outdated Show resolved Hide resolved
aeon/networks/_dcnn.py Show resolved Hide resolved
aeon/networks/_dcnn.py Outdated Show resolved Hide resolved
aeon/networks/_dcnn.py Outdated Show resolved Hide resolved
aeon/networks/_dcnn.py Outdated Show resolved Hide resolved
aeon/networks/_dcnn.py Outdated Show resolved Hide resolved
@aadya940
Copy link
Contributor Author

Done :-) , Thanks for the quick review.

@aadya940 aadya940 changed the title [ENH] Add DCNNEncoderNetwork [ENH] Add DCNNNetwork May 28, 2024
@hadifawaz1999
Copy link
Contributor

make an issue to add again the weight normalization code

@MatthewMiddlehurst MatthewMiddlehurst added the codecov actions Run the codecov action on a PR label Jun 5, 2024
hadifawaz1999
hadifawaz1999 previously approved these changes Jun 14, 2024
Copy link
Contributor

@hadifawaz1999 hadifawaz1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@MatthewMiddlehurst
Copy link
Member

make an issue to add again the weight normalization code

Was this done?

@aadya940
Copy link
Contributor Author

make an issue to add again the weight normalization code

Was this done?

Nope, will do it.

Copy link
Contributor

@hadifawaz1999 hadifawaz1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM this one given its not an AUTO ENCODER network, you can remove the temporal_latent_space thing
And you should add the _config parameter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
codecov actions Run the codecov action on a PR enhancement New feature, improvement request or other non-bug code enhancement networks Networks package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants