-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Add DCNNNetwork #1576
base: main
Are you sure you want to change the base?
[ENH] Add DCNNNetwork #1576
Conversation
Thank you for contributing to
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good start, a few comments on the network
Done :-) , Thanks for the quick review. |
make an issue to add again the weight normalization code |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Was this done? |
Nope, will do it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM this one given its not an AUTO ENCODER network, you can remove the temporal_latent_space thing
And you should add the _config parameter
Implement Dilated Convolutional Neural Network based Auto-Encoder.