Force recreating DNS record when type changes #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When updating the type of a DNS record resource, the old record is not removed because only records that match the new type of the resource are removed. A new record with the new type is created though. The resource keeps tracking the old record, because the type is part of the ID, and the ID does not change. While it is technically possible to update the ID, it rarely happens. When the type of a DNS record changes, it can also be considered a new record because the meaning of the record changes significantly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When updating the type of a DNS record resource, the old record is not removed because only records that match the new type of the resource are removed. A new record with the new type is created though.
The resource keeps tracking the old record, because the type is part of the ID, and the ID does not change. While it is technically possible to update the ID, it rarely happens. When the type of a DNS record changes, it can also be considered a new record because the meaning of the record changes significantly.