-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pipeline for releasing Docker init container #116
base: master
Are you sure you want to change the base?
Conversation
thanks @kilmajster , this is really nice! I'll have a look through it this week and hopefully we can merge it. |
Do Jankinsfile will be still needed with this pipeline or I can remove it as well? |
…-spi � Conflicts: � build.gradle � gradle.properties
@kilmajster @pb82 Is there already more infos what this PR can be merged? |
Hi @sbaerlocher, this PR seems to be little bit forgotten ;) I merged it with upstream and promoted test release to confirm that is still working (pipeline: https://github.com/kilmajster/keycloak-metrics-spi/runs/5828438512?check_suite_focus=true and docker: https://hub.docker.com/repository/docker/kilmajster/keycloak-metrics-spi). I am not a member of the project so I can't merge it. @pb82 I saw that pom.xml was added, if you are switching to this project to maven I can change this pipeline to maven one. Also in my similar personal project I got pipeline that is able to release artifact to maven central, so if you are interested in such mechanism I will be happy to help with this :) |
I'd love to see this (or something like it) merged. It looks like it needs a rebase at the moment? |
# Conflicts: # README.md # build.gradle # gradle.properties
is up to date now :) |
Looks like it may need to be rebased again since the 4.0.0 release @diversit would you be able to review/merge this? |
I am happy to review but I’m on holiday now so that would be end of august
earliest.
…On Wed, 9 Aug 2023 at 05:05, James Callahan ***@***.***> wrote:
is up to date now :)
Looks like it may need to be rebased again since the 4.0.0 release
@diversit <https://github.com/diversit> would you be able to review/merge
this?
It'd be a huge help for us manage a deployment of keycloak-metrics-spi
—
Reply to this email directly, view it on GitHub
<#116 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADWJVKH2YCD3D3PUSGDA7TXUL47NANCNFSM5GWAVAZA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
It's the end of August now :) |
Yes, I’ll review it tomorrow and get back to you
…On Tue, 29 Aug 2023 at 14:34, James Callahan ***@***.***> wrote:
I am happy to review but I’m on holiday now so that would be end of august
earliest.
It's the end of August now :)
@diversit <https://github.com/diversit> would you be able to review? Do
you need @kilmajster <https://github.com/kilmajster> to rebase?
—
Reply to this email directly, view it on GitHub
<#116 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADWJVN26UNJN3MW6PR436TXXXOXBANCNFSM5GWAVAZA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
# Conflicts: # build.gradle # gradle.properties # pom.xml
I've synced my changes with an upstream and also bumped java version to 17 in the release job - here is a pipeline I ran to promote test release with my personal docker hub creds https://github.com/kilmajster/keycloak-metrics-spi/actions/runs/6016566819/job/16320824108 |
@diversit ping? |
hi, any news for this topic ? |
@kilmajster Is this PR still relevant? |
Hi, I've created Github action based pipeline that allows to promote release by Github release form. It adds built jar file into Github release and also creates and publishes init container into Docker hub. To make this 100% working you'd need to have account on Docker hub and create repo for this project, then create token that will allow the pipeline to publish image into Docker hub. Token from Docker hub should be added to this Github repo as repository secret called
DOCKER_HUB_TOKEN
. Working test release can be found in my fork hereIf you need more details about configuration, just let me know :)
Regards, Łukasz Włódarczyk
Motivation
#34
What
Pipeline that publishes jar into Github releases and init container into Docker hub
Why
To allow using this provider with Helm charts
How
Release process with this pipeline looks like following:
2.5.3
latest
Verification Steps
You can verify that jar is added into Github release in my fork here
To verify if docker container contains jar file you can do following:
Checklist:
Progress
Additional Notes