refactor

aerospike · Sep 18, 2024 · cbe2967 · cbe2967
1 parent 10e7532
commit cbe2967
Showing 1 changed file with 12 additions and 12 deletions.
diff --git a/src/main/client/info.c b/src/main/client/info.c
@@ -95,21 +95,21 @@ static bool AerospikeClient_InfoAll_each(as_error *err, const as_node *node,
     Py_DECREF(py_res);
 
 CLEANUP:
-    if (udata_ptr->error.code != AEROSPIKE_OK) {
-        // TODO
-        raise_exception(&udata_ptr->error);
-        PyGILState_Release(gil_state);
-        return false;
-    }
-    if (err->code != AEROSPIKE_OK) {
-        // TODO
-        raise_exception(err);
-        PyGILState_Release(gil_state);
-        return false;
+    bool result = true;
+    if (udata_ptr->error.code != AEROSPIKE_OK || err->code != AEROSPIKE_OK) {
+        as_error *error;
+        if (udata_ptr->error.code != AEROSPIKE_OK) {
+            error = &udata_ptr->error;
+        }
+        else {
+            error = err;
+        }
+        raise_exception(error);
+        result = false;
     }
 
     PyGILState_Release(gil_state);
-    return true;
+    return result;
 }
 
 /**