Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLIENT-2218] Remove unfinished async code #462

Merged
merged 2 commits into from
Jul 19, 2023

Conversation

juliannguyen4
Copy link
Collaborator

@juliannguyen4 juliannguyen4 commented Jul 5, 2023

@juliannguyen4 juliannguyen4 force-pushed the CLIENT-2218-rm-async-code branch 2 times, most recently from caffbe3 to 1d9c74c Compare July 5, 2023 16:40
@codecov-commenter
Copy link

codecov-commenter commented Jul 5, 2023

Codecov Report

Patch coverage has no change and project coverage change: +1.71 🎉

Comparison is base (3747ddb) 79.41% compared to head (246b755) 81.13%.

Additional details and impacted files
@@            Coverage Diff             @@
##            stage     #462      +/-   ##
==========================================
+ Coverage   79.41%   81.13%   +1.71%     
==========================================
  Files         101       98       -3     
  Lines       15013    14695     -318     
==========================================
  Hits        11923    11923              
+ Misses       3090     2772     -318     
Impacted Files Coverage Δ
src/main/aerospike.c 85.86% <ø> (+6.07%) ⬆️
src/main/calc_digest.c 78.57% <ø> (+2.70%) ⬆️
src/main/client/type.c 74.35% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@juliannguyen4 juliannguyen4 marked this pull request as ready for review July 18, 2023 16:17
Copy link
Contributor

@dwelch-spike dwelch-spike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@juliannguyen4 juliannguyen4 merged commit e16d9bd into stage Jul 19, 2023
@juliannguyen4 juliannguyen4 deleted the CLIENT-2218-rm-async-code branch July 19, 2023 16:09
@KimSoungRyoul KimSoungRyoul mentioned this pull request Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants