Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLIENT-2539] Prevent potential crashes if C client receives invalid string data from the server #588

Draft
wants to merge 9 commits into
base: dev
Choose a base branch
from

Conversation

juliannguyen4
Copy link
Collaborator

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Mar 12, 2024

Codecov Report

Attention: Patch coverage is 35.71429% with 54 lines in your changes missing coverage. Please review.

Project coverage is 80.63%. Comparing base (8ff0327) to head (651635f).
Report is 4 commits behind head on dev.

Files with missing lines Patch % Lines
src/main/conversions.c 34.78% 30 Missing ⚠️
src/main/client/set_xdr_filter.c 0.00% 5 Missing ⚠️
src/main/serializer.c 16.66% 5 Missing ⚠️
src/main/client/info_random_node.c 20.00% 4 Missing ⚠️
src/main/client/info_single_node.c 20.00% 4 Missing ⚠️
src/main/client/get_cdtctx_base64.c 50.00% 2 Missing ⚠️
src/main/client/get_expression_base64.c 50.00% 2 Missing ⚠️
src/main/geospatial/type.c 77.77% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #588      +/-   ##
==========================================
- Coverage   80.89%   80.63%   -0.27%     
==========================================
  Files         100      100              
  Lines       15053    15124      +71     
==========================================
+ Hits        12177    12195      +18     
- Misses       2876     2929      +53     
Flag Coverage Δ
?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@juliannguyen4 juliannguyen4 changed the title [CLIENT-2539] Fix GeoJSON string crash [CLIENT-2539] Fix potential crashes if C client receives invalid string data from the server Mar 12, 2024
@juliannguyen4 juliannguyen4 changed the title [CLIENT-2539] Fix potential crashes if C client receives invalid string data from the server [CLIENT-2539] Prevent potential crashes if C client receives invalid string data from the server Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants