Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLIENT-2842] Fix client config batch_write, batch_remove, and batch_apply policies not being applied to Write, Remove, and Apply BatchRecords respectively #591

Merged
merged 4 commits into from
Apr 26, 2024

Conversation

juliannguyen4
Copy link
Collaborator

@juliannguyen4 juliannguyen4 commented Mar 27, 2024

Extra changes:

  • build-wheels.yml: upload macOS and manylinux wheels to Github even if the tests fail

It's already documented that these 3 policies apply to Write, Apply, and Remove BatchRecords here: https://aerospike-python-client--591.org.readthedocs.build/en/591/client.html#batch-write-policies

@juliannguyen4 juliannguyen4 changed the title [CLIENT-2842] Fix client config batch_write policy not being applied to Write BatchRecords [CLIENT-2842] Fix client config batch_write, batch_remove, and batch_apply policies not being applied to Write, Remove, and Apply BatchRecords respectively Mar 28, 2024
@juliannguyen4 juliannguyen4 marked this pull request as ready for review April 1, 2024 22:54
@codecov-commenter
Copy link

codecov-commenter commented Apr 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.35%. Comparing base (4bfcfae) to head (4f64332).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #591      +/-   ##
==========================================
+ Coverage   81.34%   81.35%   +0.01%     
==========================================
  Files         100      100              
  Lines       15355    15355              
==========================================
+ Hits        12490    12492       +2     
+ Misses       2865     2863       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@juliannguyen4 juliannguyen4 force-pushed the CLIENT-2842-global-batch-write-fix branch from cc06935 to 8e2130c Compare April 5, 2024 22:47
@juliannguyen4 juliannguyen4 force-pushed the CLIENT-2842-global-batch-write-fix branch from 0e66f69 to 2b2f4a3 Compare April 15, 2024 20:34
@juliannguyen4 juliannguyen4 force-pushed the CLIENT-2842-global-batch-write-fix branch from 2b2f4a3 to 42470cd Compare April 18, 2024 22:52
Copy link
Contributor

@justinlee-aerospike justinlee-aerospike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes look good

@juliannguyen4 juliannguyen4 merged commit dc46dc7 into dev Apr 26, 2024
56 checks passed
@juliannguyen4 juliannguyen4 deleted the CLIENT-2842-global-batch-write-fix branch April 26, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants