-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DEVOPS-234] CI/CD: Build manylinux wheels and upload them to JFrog on every push to an arbitrary branch #606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #606 +/- ##
=======================================
Coverage 81.35% 81.35%
=======================================
Files 100 100
Lines 15358 15358
=======================================
Hits 12494 12494
Misses 2864 2864 ☔ View full report in Codecov by Sentry. |
juliannguyen4
changed the title
[CLIENT-1837] CI/CD: Build manylinux wheels on every push to a branch
[CLIENT-1837] CI/CD: Build manylinux wheels on every push to a branch and upload to JFrog
Apr 30, 2024
juliannguyen4
changed the title
[CLIENT-1837] CI/CD: Build manylinux wheels on every push to a branch and upload to JFrog
[DEVOPS-234] CI/CD: Build manylinux wheels and upload them to JFrog on every push to an arbitrary branch
May 7, 2024
justinlee-aerospike
approved these changes
May 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes look good
DomPeliniAerospike
added a commit
that referenced
this pull request
May 22, 2024
* [CLIENT-1837] CI/CD: Label version with git commit when building on a non-tagged commit (#605) * Also label version when building unoptimized, with macOS debug support, or with uncommitted changes to the repo (i.e add a "dirty" label) * Rename config.conf to config.conf.template and add config.conf to .gitignore, so creating and modifying config.conf won't cause the repo to be in a dirty state * Auto-bump version to 15.0.1rc3.dev1 [skip ci] * [DEVOPS-234] CI/CD: Build manylinux wheels and upload them to JFrog on every push to an arbitrary branch (#606) * CI/CD: Add option to build and upload unoptimized wheels to JFrog for QE * Auto-bump version to 15.0.1rc3.dev2 [skip ci] --------- Co-authored-by: juliannguyen4 <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extra changes: When status checks for a workflow are shown due to a push or pull_request event, it will also show status checks for any reusable workflow in it. Only show status check for build-wheels.yml if it's not triggered by a pull request or push event. This prevents status checks for the same build-wheels.yml run from showing twice--one from the workflow that called build-wheels.yml, and another from the build-wheels.yml workflow itself
build-wheels.yml will build wheels on all platforms, but we can optimize this later to only build the manylinux artifacts so we don't waste resources to build the other wheels we don't need
No regression for upload-to-jfrog.yml: https://github.com/aerospike/aerospike-client-python/actions/runs/9177026728
dev-test
branch and a test JFrog repo to check that artifacts are still uploaded to the JFrog PyPI repo properly