-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CLIENT-2856] Docs: Clarify how map policy works for all map operations that use it #614
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #614 +/- ##
=======================================
Coverage 81.35% 81.35%
=======================================
Files 100 100
Lines 15355 15356 +1
=======================================
+ Hits 12492 12493 +1
Misses 2863 2863 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one wording change
Co-authored-by: justinlee-aerospike <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes look good
Extra changes
Doc changes
Default value for persist_index: https://aerospike-python-client--614.org.readthedocs.build/en/614/client.html#map-policies
map_set_policy() description changed: https://aerospike-python-client--614.org.readthedocs.build/en/614/aerospike_helpers.operations.html#aerospike_helpers.operations.map_operations.map_set_policy
Map API description changed:
https://aerospike-python-client--614.org.readthedocs.build/en/614/aerospike_helpers.operations.html#aerospike_helpers.operations.map_operations.map_increment
https://aerospike-python-client--614.org.readthedocs.build/en/614/aerospike_helpers.operations.html#aerospike_helpers.operations.map_operations.map_decrement