-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CLIENT-3017] CI/CD: Wait for Aerospike server Docker container to be ready using asinfo instead of a time delay #642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #642 +/- ##
=======================================
Coverage 81.33% 81.33%
=======================================
Files 100 100
Lines 15341 15341
=======================================
Hits 12477 12477
Misses 2864 2864 ☔ View full report in Codecov by Sentry. |
This reverts commit 9c3300a.
juliannguyen4
added
the
new-server-features
Test against the latest server release candidate
label
Jul 8, 2024
juliannguyen4
requested review from
justinlee-aerospike
and removed request for
justinlee-aerospike
July 8, 2024 15:47
…case script has a bug
justinlee-aerospike
approved these changes
Jul 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes are fine
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extra changes
PR tests pass (except for failure unrelated to this change). see status checks
dev-workflow-p1 passes: https://github.com/aerospike/aerospike-client-python/actions/runs/9844997400/job/27180101352
Stage tests pass: https://github.com/aerospike/aerospike-client-python/actions/runs/9845019760
Valgrind passes: https://github.com/aerospike/aerospike-client-python/actions/runs/9845023815