Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLIENT-2897] Show class name when printing a aerospike_helpers.HyperLogLog class instance #659

Merged
merged 4 commits into from
Aug 27, 2024

Conversation

juliannguyen4
Copy link
Collaborator

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Aug 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.33%. Comparing base (856d43d) to head (5d85ea3).
Report is 3 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #659   +/-   ##
=======================================
  Coverage   81.33%   81.33%           
=======================================
  Files         100      100           
  Lines       15341    15346    +5     
=======================================
+ Hits        12477    12482    +5     
  Misses       2864     2864           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@juliannguyen4 juliannguyen4 marked this pull request as ready for review August 27, 2024 20:56
Copy link
Contributor

@dwelch-spike dwelch-spike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@juliannguyen4
Copy link
Collaborator Author

juliannguyen4 commented Aug 27, 2024

There's a bug where dev workflow p1 is testing against the latest server RC instead of the latest server release. This will be fixed in another PR asap.

Since build wheels passed before with the latest server release, I think this is still safe to merge

@juliannguyen4 juliannguyen4 merged commit a55129c into dev Aug 27, 2024
107 of 134 checks passed
@juliannguyen4 juliannguyen4 deleted the CLIENT-2897-hyperloglog-repr branch August 27, 2024 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants