Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLIENT-3106] Refactor policy code (complete refactor) #665

Draft
wants to merge 42 commits into
base: dev
Choose a base branch
from

Conversation

juliannguyen4
Copy link
Collaborator

@juliannguyen4 juliannguyen4 commented Sep 5, 2024

  • Replace macros for setting policies with inline code to make easier to debug and read, as well as to keep all the conversion code in one place and reduce the number of codepaths

@codecov-commenter
Copy link

codecov-commenter commented Sep 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (d1e7bc2) to head (ae25f79).
Report is 14 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #665       +/-   ##
==========================================
- Coverage   80.96%   0.00%   -80.97%     
==========================================
  Files         100      17       -83     
  Lines       15130    3621    -11509     
==========================================
- Hits        12250       0    -12250     
- Misses       2880    3621      +741     
Flag Coverage Δ
0.00% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@juliannguyen4 juliannguyen4 changed the title [CLIENT-3106] Refactor policy code [CLIENT-3106] Refactor policy code (complete refactor) Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants