-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stage #131
Conversation
…Type#MAP_UNORDERED
Set bool return type for list read expressions with ListReturnType.EXISTS. Set bool return type for map read expressions with MapReturnType.EXISTS. Set map return type for map read expressions with MapReturnType.UNORDERED_MAP or MapReturnType.ORDERED_MAP.
…r automated unit/integration functional tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes look good. A few minor comments, and you may want to check with Ronen about if this should be a major release or not.
CHANGELOG.md
Outdated
@@ -2,6 +2,27 @@ | |||
|
|||
All notable changes to this project will be documented in this file. | |||
|
|||
## [3.1.0] 2024-08-14 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since you removed stuff from the interface - should this be a major version release?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing has been removed from the interface, just behind the scene functionality that we mentioned on major release that would be unsupported.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I lied. Predexp
was public, but still mentioned in the release notes for v3 that the client only supports servers v6 and later. PredExp
was deprecated in v5.6 and removed in v6 more than 2 years ago.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bumped the version to v4.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes look good
[3.1.0] 2024-08-14
New Features
MapReturnType#MAP_ORDERED
andMapReturnType#MAP_UNORDERED
.Exp#infinity_val
andExp#wildcard_val
.Updates
Predexp
andBatchDirect
).Improvements