Om86 #101
Merged
Om86 #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
support for micro benchmarks issue micro-benchmark commands during latency-watcher passtwo keys namespace-watcher and node-watcher add respective namespace and service benchmark flags which are later consumed by latency-watcher
sunilvirus
reviewed
Nov 29, 2023
watcher_namespaces.go
Outdated
| } | ||
| } | ||
| // append default re-repl, as this auto-enabled, but not coming as part of latencies, we need this as namespace is available only here | ||
| LatencyBenchmarks[nsName+"-latency-hist-re-repl"] = "{" + nsName + "}-re-repl" |
There was a problem hiding this comment.
This should be done outside the for loop. isnt it ?
Else, it will get added again and again to the map.
Luckily this is not a bug as the same element gets added to the map.
sunilvirus
reviewed
Nov 29, 2023
watcher_latency.go
Outdated
| @@ -56,10 +60,25 @@ func (lw *LatencyWatcher) refresh(o *Observer, infoKeys []string, rawMetrics map | |||
| } | |||
| } | |||
|
|
|||
| // loop all the latency infokeys | |||
| for ik := range infoKeys { | |||
There was a problem hiding this comment.
This can be simplified by directly accessing values in loop.
for _, key := range infoKeys {
...
use the key directly instead of accessing via the index again.
sunilvirus
reviewed
Nov 29, 2023
watcher_latency.go
Outdated
| var commands = []string{"latencies:"} | ||
|
|
||
| // below latency-command are added to the auto-enabled list, i.e. latencies: command | ||
| // re-repl is auto-enabled, but not coming as part of latencies: list, hence we are adding it explicitly |
There was a problem hiding this comment.
re-repl comment here is not relevant anymore.
sunilvirus
reviewed
Nov 29, 2023
watcher_namespaces.go
Outdated
| LatencyBenchmarks[nsName+"-"+stat] = stat | ||
| } | ||
| } | ||
| // append default re-repl, as this auto-enabled, but not coming as part of latencies, we need this as namespace is available only here |
There was a problem hiding this comment.
Let not add this. Because once the server starts giving this by default, we will end up duplicating this. Else, we have to do a server version check and add extra logic.
removed - re-repl hist command modified the for loop removed unnecessary comments
sunilvirus
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
support for micro benchmarks
issue micro-benchmark commands during latency-watcher passtwo keys
namespace-watcher and node-watcher add respective namespace and service benchmark flags which are later consumed by latency-watcher