Disable CGO since it isn't used. #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change will make the binaries work on any distro, as long as it's linux and the amd64/arm64 architecture matches, removing the need to have a separate binary for each distribution and distro version (no more libc requirement). Disabling CGO does not have an effect on this application functionality. It does however mean that a single amd64-compiled binary will work on every amd64 linux distribution and version.
|
@robertglonek thanks for the PR. As this is too close to our release (in 2 days), we will take this as part of our next release. |
Awesome thank you. |
sunilvirus
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change will make the binaries work on any distro, as long as it's linux and the amd64/arm64 architecture matches, removing the need to have a separate binary for each distribution and distro version (no more libc requirement). Disabling CGO does not have an effect on this application functionality. It does however mean that a single amd64-compiled binary will work on every amd64 linux distribution and version.