Merge 92 94 #92
Merged
Merge 92 94 #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
initial check-in to handle index-type configs TODO: cover flash, pmem, shmem
handled array type of stats like flash pmem device/ file
initial commit of refresh-configs along with stats
refactored xdr to fetch dc-config, dc-namespace config and dc-namespace-stats also moved config command into passTwoKeys in node-stats moved "build" command from latency-watcher to observer as it is common for all watchers, this will remove ordering watchers while parsing refactored passone and passtwo variable to suite the usecase
incorporated review feedback on return error and unnecessary error handling removed fmt.printlns and corrected log-level to warn
cluster-name and service are null while sending index-type and storage-engine stats
added sindex handling along with storage and index enhanced the test-case structure
corrected node-stats reading config command refactored node-stats config and stats in same utility added comments and removed unnecessary code
added raw-metrics dump code - this is required to validate exporter values during each refresh iteration
adding persistance-type in labels refactoring test-cases
test-case cleanup and re-organised
removed comments and fmt.printlns
removed metric dump to local files.
tried to optimize and remove unnecessary code
optimized code and removed unnecessary code
moved constants back to common.go, this will avoid cyclical dependency between watcher-namespace and common.go
added common method to push to prometheus removed commented code
removed additional _ (underscore) which is appended to the metric
Om92 - merge for testing
fixed merged code functional issues in watcher_namespace updated test-cases to handle passOneKeys, passTwoKeys and XDR test-cases to handle xdr-config, xdr-stats refactored watcher-xdr, warcher-set, watcher-sindex, to use common method to push data to prom.
fixed lint issues
added index-pressure refresh logic
added code to fetch index-pressure from server every 10 minutes. reviewed and cleanup Gauge-list stats removed unwanted code
fixed failing test-cases after updating the gauge-list config toml file
spkesan
reviewed
Aug 21, 2023
| // sanitize the utf8 strings before sending them to watchers | ||
| for k, v := range rawMetrics { | ||
| rawMetrics[k] = sanitizeUTF8(v) | ||
| } | ||
|
|
||
| // sanitize the utf8 strings before sending them to watchers |
There was a problem hiding this comment.
need to remove this comment (duplicate)
spkesan
reviewed
Aug 22, 2023
Co-authored-by: SP Kesan <[email protected]>
Co-authored-by: SP Kesan <[email protected]>
Co-authored-by: SP Kesan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added support for index-pressure
added support for stats and configs at XDR-DC and XDR-DC-Namespace level
moved prometheus push logic to a common function