Skip to content

Commit

Permalink
update go client
Browse files Browse the repository at this point in the history
  • Loading branch information
dwelch-spike committed Oct 22, 2024
1 parent f49c449 commit 528ce59
Show file tree
Hide file tree
Showing 5 changed files with 15 additions and 12 deletions.
2 changes: 1 addition & 1 deletion cmd/indexCreate.go
Original file line number Diff line number Diff line change
Expand Up @@ -231,7 +231,7 @@ asvec index create -i myindex -n test -s testset -d 256 -m COSINE --%s vector \
slog.Any(flags.HnswEf, indexCreateFlags.hnswEf.Val),
slog.Any(flags.HnswConstructionEf, indexCreateFlags.hnswConstructionEf.Val),
slog.Any(flags.HnswMaxMemQueueSize, indexCreateFlags.hnswMaxMemQueueSize.Val),
slog.Any(flags.EnableVectorIntegrityCheck, indexCreateFlags.enableVectorIntegrityCheck),
slog.Any(flags.EnableVectorIntegrityCheck, indexCreateFlags.enableVectorIntegrityCheck.Val),
)...,
)

Expand Down
2 changes: 1 addition & 1 deletion cmd/indexUpdate.go
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ asvec index update -i myindex -n test --%s 10000 --%s 10000ms --%s 10s --%s 16 -
slog.String(flags.IndexName, indexUpdateFlags.indexName),
slog.Any(flags.IndexLabels, indexUpdateFlags.indexLabels),
slog.String(flags.HnswMaxMemQueueSize, indexUpdateFlags.hnswMaxMemQueueSize.String()),
slog.Any(flags.EnableVectorIntegrityCheck, indexUpdateFlags.enableVectorIntegrityCheck),
slog.String(flags.EnableVectorIntegrityCheck, indexUpdateFlags.enableVectorIntegrityCheck.String()),
)...,
)

Expand Down
19 changes: 10 additions & 9 deletions e2e_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -544,15 +544,16 @@ func (suite *CmdTestSuite) TestSuccessfulUpdateIndexCmd() {
WithHnswMergeReIndexParallelism(11).
Build(),
},
{
name: "test with enable vector integrity check",
indexName: "successful-update",
indexNamespace: "test",
cmd: "index update -y -n test -i successful-update --enable-vector-integrity-check false",
expectedIndex: newBuilder().
WithEnableVectorIntegrityCheck(false).
Build(),
},
// TODO enable this when it works in the server
// {
// name: "test with enable vector integrity check",
// indexName: "successful-update",
// indexNamespace: "test",
// cmd: "index update -y -n test -i successful-update --enable-vector-integrity-check false",
// expectedIndex: newBuilder().
// WithEnableVectorIntegrityCheck(false).
// Build(),
// },
}

for _, tc := range testCases {
Expand Down
2 changes: 1 addition & 1 deletion go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ module asvec
go 1.22.5

require (
github.com/aerospike/avs-client-go v0.0.0-20241021200908-69baf3bf651d
github.com/aerospike/avs-client-go v0.0.0-20241022175841-0802ad7be5d7
github.com/aerospike/tools-common-go v0.0.0-20240927170813-c352c1917359
github.com/jedib0t/go-pretty/v6 v6.5.9
github.com/spf13/cobra v1.8.1
Expand Down
2 changes: 2 additions & 0 deletions go.sum
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@ github.com/aerospike/avs-client-go v0.0.0-20241017232653-891999137417 h1:VWfR8GV
github.com/aerospike/avs-client-go v0.0.0-20241017232653-891999137417/go.mod h1:gveJAyzXlND0g/lA+R6USRg9UcnGAUtyHzcngWrHSTo=
github.com/aerospike/avs-client-go v0.0.0-20241021200908-69baf3bf651d h1:IO+H1Qea5bfxH2WEFntc5mO1tldAi4WLMXtX/rmif7c=
github.com/aerospike/avs-client-go v0.0.0-20241021200908-69baf3bf651d/go.mod h1:gveJAyzXlND0g/lA+R6USRg9UcnGAUtyHzcngWrHSTo=
github.com/aerospike/avs-client-go v0.0.0-20241022175841-0802ad7be5d7 h1:V9MX8SxKPld/jotSLE6VfMaSGUnyZ5s77TlIz7RrS4M=
github.com/aerospike/avs-client-go v0.0.0-20241022175841-0802ad7be5d7/go.mod h1:gveJAyzXlND0g/lA+R6USRg9UcnGAUtyHzcngWrHSTo=
github.com/aerospike/tools-common-go v0.0.0-20240927170813-c352c1917359 h1:NXCigFN6GWJizwJSe7xAp5kTz7ZxdNjpyRxaIp6MkuA=
github.com/aerospike/tools-common-go v0.0.0-20240927170813-c352c1917359/go.mod h1:Ig1lRynXx0tXNOY3MdtanTsKz1ifG/2AyDFMXn3RMTc=
github.com/cpuguy83/go-md2man/v2 v2.0.4/go.mod h1:tgQtvFlXSQOSOSIRvRPT7W67SCa46tRHOmNcaadrF8o=
Expand Down

0 comments on commit 528ce59

Please sign in to comment.