Skip to content

Commit

Permalink
review changes
Browse files Browse the repository at this point in the history
  • Loading branch information
dwelch-spike committed Oct 23, 2024
1 parent db403ac commit ec0be38
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 4 deletions.
5 changes: 3 additions & 2 deletions cmd/flags/hnsw.go
Original file line number Diff line number Diff line change
Expand Up @@ -53,10 +53,11 @@ func NewHnswCachingFlags() *CachingFlags {
}
}

//nolint:lll // For readability
func (cf *CachingFlags) NewFlagSet() *pflag.FlagSet {
flagSet := &pflag.FlagSet{}
flagSet.Var(&cf.MaxEntries, HnswCacheMaxEntries, "Maximum number of entries to cache.") //nolint:lll // For readability
flagSet.Var(&cf.Expiry, HnswCacheExpiry, "A cache entry will expire after this amount of time has passed since the entry was added to cache") //nolint:lll // For readability
flagSet.Var(&cf.MaxEntries, HnswCacheMaxEntries, "Maximum number of entries to cache.")
flagSet.Var(&cf.Expiry, HnswCacheExpiry, "A cache entry will expire after this amount of time has passed since the entry was added to cache")

return flagSet
}
Expand Down
4 changes: 2 additions & 2 deletions e2e_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -771,7 +771,7 @@ Batch Max Index Records*\,100000
Batch Index Interval*\,30s
Batch Max Reindex Records*\,10000
Batch Reindex Interval*\,30s
Cache Max Entires*\,2000000
Cache Max Entries*\,2000000
Cache Expiry*\,1h0m0s
Healer Max Scan Rate / Node*\,1000
Healer Max Page Size*\,10000
Expand All @@ -791,7 +791,7 @@ Batch Max Index Records*\,100000
Batch Index Interval*\,30s
Batch Max Reindex Records*\,10000
Batch Reindex Interval*\,30s
Cache Max Entires*\,2000000
Cache Max Entries*\,2000000
Cache Expiry*\,1h0m0s
Healer Max Scan Rate / Node*\,1000
Healer Max Page Size*\,10000
Expand Down

0 comments on commit ec0be38

Please sign in to comment.