Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FMWK-556 Add folder validation before restore #156

Merged
merged 5 commits into from
Oct 6, 2024

Conversation

filkeith
Copy link
Contributor

@filkeith filkeith commented Oct 2, 2024

  • check if directory is not empty

@codecov-commenter
Copy link

codecov-commenter commented Oct 2, 2024

Codecov Report

Attention: Patch coverage is 74.73684% with 24 lines in your changes missing coverage. Please review.

Project coverage is 80.25%. Comparing base (4affbb7) to head (79f9278).

Files with missing lines Patch % Lines
io/aws/s3/reader.go 51.72% 11 Missing and 3 partials ⚠️
io/gcp/storage/reader.go 80.76% 3 Missing and 2 partials ⚠️
io/local/reader.go 81.25% 2 Missing and 1 partial ⚠️
io/azure/blob/reader.go 91.66% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #156      +/-   ##
==========================================
+ Coverage   80.22%   80.25%   +0.03%     
==========================================
  Files          93       93              
  Lines        5076     5167      +91     
==========================================
+ Hits         4072     4147      +75     
- Misses        706      715       +9     
- Partials      298      305       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

- added validator
- added nested dirs
@filkeith filkeith marked this pull request as ready for review October 6, 2024 07:44
- nested folder check fix
@filkeith filkeith merged commit 14f2a56 into main Oct 6, 2024
9 checks passed
@filkeith filkeith deleted the FMWK-556-restore-folder-validation branch October 6, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants