Dev #1
Open
Dev #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Buffer always cleared to background color instead of black, so no more blinking when picking is enabled
|
Wow, thanks. It'll take some time to review, but this sounds great. We'll try that code on large code bases to see if it breaks anything. If it does, we'll have to ask for separate pull requests so we can review them separately. |
Conflicts: src/aerys/minko/render/material/phong/PhongEffect.as src/aerys/minko/render/material/phong/PhongSinglePassShader.as
…ng Minko with Starling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several fixes
I don't know how to do separate pull requests but commits involve one single file so it should be easy to cherry-pick